Event-based Puzzles #47
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Making puzzles be owned by events, as a way to play with object relationships. The "CLICK HERE TO CHECK YOUR DATABASE SETUP" link now points to Events instead of Puzzles, and the Events index has a new link to access that event's puzzle list. I've needed to pass the event ID around, and the event ID should probably be part of some global context, but this is a helpful microcosm of issues we'll have when doing other features so I still think it's a good start.
morganbr
approved these changes
Aug 29, 2018
ServerCore/Pages/Events/Index.cshtml
Outdated
| @@ -19,6 +19,7 @@ | |||
| <th> | |||
| @Html.DisplayNameFor(model => model.Event[0].UrlString) | |||
| </th> | |||
| <!-- | |||
There was a problem hiding this comment.
Please remove commented out code.
| @@ -27,17 +28,21 @@ public IActionResult OnGet() | |||
| [BindProperty] | |||
| public Puzzle Puzzle { get; set; } | |||
|
|
|||
| public async Task<IActionResult> OnPostAsync() | |||
| public async Task<IActionResult> OnPostAsync(int? eventid) | |||
There was a problem hiding this comment.
Should we require having an event id? We probably don't want puzzles that aren't in events
| _context.Puzzle.Add(Puzzle); | ||
| await _context.SaveChangesAsync(); | ||
|
|
||
| return RedirectToPage("./Index"); | ||
| return RedirectToPage("./Index", new { eventid = eventid }); |
There was a problem hiding this comment.
FYI @asyasky, take a look at how we should be doing this (but no need to block on this)
| { | ||
| Puzzle = await _context.Puzzle.ToListAsync(); | ||
| if (eventid != null) |
There was a problem hiding this comment.
Please file an issue tracking removing the null tolerance since we don't want people accidentally wandering into all puzzles in all events
|
Changes made, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Making puzzles be owned by events, as a way to play with object
relationships.
The "CLICK HERE TO CHECK YOUR DATABASE SETUP" link now points to Events
instead of Puzzles, and the Events index has a new link to access that
event's puzzle list.
I've needed to pass the event ID around, and the event ID should
probably be part of some global context, but this is a helpful microcosm
of issues we'll have when doing other features so I still think it's a
good start.